Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors to prepare for moving the aggregation logic back into the workers #747

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Refactors to prepare for moving the aggregation logic back into the workers #747

merged 6 commits into from
Jan 3, 2025

Conversation

mendess
Copy link
Collaborator

@mendess mendess commented Dec 19, 2024

No description provided.

@mendess mendess force-pushed the mendess/small-changes branch 2 times, most recently from a717a8f to 65b0086 Compare December 19, 2024 16:48
cjpatton
cjpatton reviewed Dec 19, 2024
View reviewed changes
crates/daphne/src/constants.rs Outdated Show resolved Hide resolved
crates/daphne/src/vdaf/prio3.rs Outdated Show resolved Hide resolved
@mendess mendess force-pushed the mendess/small-changes branch 2 times, most recently from 0241bee to f76357e Compare December 20, 2024 18:04
@mendess mendess mentioned this pull request Dec 31, 2024
Merged
cjpatton
cjpatton reviewed Jan 1, 2025
View reviewed changes
crates/daphne/src/pine/vdaf.rs Outdated Show resolved Hide resolved
crates/daphne/src/protocol/report_init.rs Outdated Show resolved Hide resolved
crates/daphne/src/vdaf/draft09.rs Outdated Show resolved Hide resolved
@mendess mendess force-pushed the mendess/small-changes branch from f76357e to 3f9f5a1 Compare January 2, 2025 13:18
@mendess mendess requested review from cjpatton and jhoyla January 2, 2025 17:25
cjpatton
cjpatton reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the two remaining comments.

@mendess mendess force-pushed the mendess/small-changes branch 2 times, most recently from 0237ebc to 16be6a7 Compare January 3, 2025 16:15
@mendess mendess force-pushed the mendess/small-changes branch from 16be6a7 to 4739207 Compare January 3, 2025 16:19
@mendess
Copy link
Collaborator Author

mendess commented Jan 3, 2025

Looks good except for the two remaining comments.

done

@mendess mendess requested a review from cjpatton January 3, 2025 16:23
@mendess mendess merged commit 4f5e776 into main Jan 3, 2025
3 checks passed
@mendess mendess deleted the mendess/small-changes branch January 3, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@armfazh armfazh Awaiting requested review from armfazh armfazh is a code owner

@bhalleycf bhalleycf Awaiting requested review from bhalleycf bhalleycf is a code owner

@fisherdarling fisherdarling Awaiting requested review from fisherdarling fisherdarling is a code owner

@cbranch cbranch Awaiting requested review from cbranch cbranch is a code owner

@lbaquerofierro lbaquerofierro Awaiting requested review from lbaquerofierro lbaquerofierro is a code owner

@RageKnify RageKnify Awaiting requested review from RageKnify RageKnify is a code owner

@jhoyla jhoyla Awaiting requested review from jhoyla jhoyla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mendess @jhoyla @cjpatton